Fix podman --noout to suppress all output

[ashley-cui]

Podman --noout was not suppressing output from commands that do not create the podman engine. Now, podman --noout properly suppresses output from every command.

Fixes: #16201

Signed-off-by: Ashley Cui [email protected]

Does this PR introduce a user-facing change?

Fixed a bug where `podman --noout` was not suppressing output from certain commands such as `podman machine` and `podman system connection`

[ashley-cui]

Little background: Commands that do not create the podman engine do not run PersistentPreRunE, so we have to do this in a hook. I think it should be safe to remove the NoOut field from pkg/domain/entities since it's not used or consumed anywhere else in the codebase other than in cmd/podman (functionally was a NoOp). This avoids an expensive registry.PodmanConfig() from inside the hook.

[Luap99]

LGTM

[edsantiago]

One nit, not a blocker. Also, while learning about --nout, I found this in podman.1.md:

Redirect stdout to /dev/null. This command will prevent all stdout from the Podman command. The --noout option will not block stderr or stdout from containers.

(emphasis mine). Should be option, not command. And the phrasing is clumsy, could be collapsed to "from the Podman command but will not block ...". Again, only if you need to re-push for other reasons.

[edsantiago]

Wrong indentation, but not worth re-pushing for. (If you need to re-push for any reason, though, please fix it)

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashley-cui, edsantiago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ashley-cui,edsantiago]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

/lgtm