Add support for --preserve-fds on FreeBSD for run and exec #16512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to support --preserve-fds in create and exec. [NO NEW TESTS NEEDED] Signed-off-by: Doug Rabson <[email protected]>
openshift-ci
bot
added
the
approved
mheon
reviewed
Nov 15, 2022
Also add a FreeBSD version. [NO NEW TESTS NEEDED] Signed-off-by: Doug Rabson <[email protected]>
dfr
force-pushed
the
freebsd-preserve-fds
branch
from
a65b262 to
4c1294c
Compare
|
LGTM |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dfr, flouthoc, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mainly involved implementing enough of rootless to support IsFdInherited. The function checkExecPreserveFDs seems redundant - it repeats the work of IdFdInherited and could be removed entirely. This extra check only happens for exec, not run.
Does this PR introduce a user-facing change?