[skip-ci] Reuse workflows #16503
Merged
[skip-ci] Reuse workflows #16503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cevich The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cevich
force-pushed
the
reuse_workflows
branch
2 times, most recently
from
78ecf25 to
a78201b
Compare
It's possible to reuse a GHA workflow from another repo with minimal YAML. However there are certain requirements, like spelling out all the required secret values. Also any mention of `ACTIONS_STEP_DEBUG` will cause failures and must be removed. As usual, there's no convenient way to test these changes without pushing to a `main` branch somewhere that also has all the proper secrets configured. However, I did pattern these changes off of a working setup in buildah: https://github.com/containers/buildah/blob/fd2d05c0a7ada9592e30a2eba941444b1d959ecf/.github/workflows/check_cirrus_cron.yml Signed-off-by: Chris Evich <[email protected]>
cevich
force-pushed
the
reuse_workflows
branch
from
a78201b to
021a23b
Compare
cevich
added a commit
to cevich/buildah
that referenced
this pull request
Nov 14, 2022
Depends on: containers/podman#16503 More features, less to maintain. Everybody wins. Signed-off-by: Chris Evich <[email protected]>
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
vrothberg
reviewed
Nov 15, 2022
|
I'm not qualified to review it either 😁 Like all the other github-action crap, we just "merge and pray" 🙏 |
|
BTW: I have no idea how you got assigned to this issue. Have you been drinking from the bad-luck fountain recently? |
|
Manually triggered test job: https://github.com/containers/podman/actions/runs/3473497963 |
cevich
added a commit
to cevich/buildah
that referenced
this pull request
Nov 15, 2022
Depends on: containers/podman#16503 More features, less to maintain. Everybody wins. Signed-off-by: Chris Evich <[email protected]>
cevich
added a commit
to cevich/buildah
that referenced
this pull request
Nov 15, 2022
Depends on: containers/podman#16503 More features, less to maintain. Everybody wins. Signed-off-by: Chris Evich <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR introduce a user-facing change?