Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the RestartSec to service for the generate cmd #16469

Closed
wants to merge 1 commit into from

Conversation

aadi58002
Copy link

@aadi58002 aadi58002 commented Nov 10, 2022

Signed-off-by: aadi58002 <aadi58002gmail.com>
Solving #16419

Does this PR introduce a user-facing change?

CLI change

@openshift-ci openshift-ci bot added the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label Nov 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 10, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aadi58002
Once this PR has been reviewed and has the lgtm label, please assign vrothberg for approval by writing /assign @vrothberg in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added release-note and removed do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None labels Nov 10, 2022
Signed-off-by: aadi58002 <aadi58002gmail.com>

Signed-off-by: aadi58002 <aadi58002gmail.com>
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Would you add a unit test to containers_test.go that sets the RestartSec option? An e2e test in https://github.com/containers/podman/blob/main/test/e2e/generate_systemd_test.go would also be great to make sure that we run podman generate systemd and check for the expected output.

@rhatdan
Copy link
Member

rhatdan commented Nov 10, 2022

Can you fix your commit message, you email message is repeated and is missing @ sign in email.
git rebase --amend -a -s
git push --force

@aadi58002
Copy link
Author

I am closing this issue as #16475 Solved the issue solved by this PR

@aadi58002 aadi58002 closed this Nov 11, 2022
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants