More log-flake work #16437
More log-flake work #16437
Conversation
It looks like containers#16132 was my fault: a missing 'wait' for a container to exit. Let's see if this fixes the flake. And, while poking through flake logs, I found another missing wait. And... in wait_for_output(), address a potential race. Signed-off-by: Ed Santiago <[email protected]>
openshift-ci
bot
added
release-note-none
approved
|
LGTM |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -65,7 +65,11 @@ var _ = Describe("Podman logs", func() { | |||
| Expect(logc).To(Exit(0)) | |||
| cid := logc.OutputToString() | |||
|
|
|||
| results := podmanTest.Podman([]string{"logs", cid}) | |||
| results := podmanTest.Podman([]string{"wait", cid}) | |||
There was a problem hiding this comment.
What is special about this test? The other test below use the same logic without wait as well.
You could also just remove the -d from podman run instead of the extra wait call.
There was a problem hiding this comment.
What's special is that this is another podman logs flake. I haven't seen flakes in those other tests, so I didn't look at them.
Removing -d was my first choice, but I realized I don't know enough about logging to know if it behaves differently under -d. I chose to assume the test author used it that way for a reason.
There was a problem hiding this comment.
Logging doesn't behave differently.
But if you use -d we will detach directly and not wait for exit, without -d we will wait for exit, thus podman wait would not be needed in that case.
[backport containers#16437] It looks like containers#16132 was my fault: a missing 'wait' for a container to exit. Let's see if this fixes the flake. And, while poking through flake logs, I found another missing wait. And... in wait_for_output(), address a potential race. Signed-off-by: Ed Santiago <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
It looks like #16132 was my fault: a missing 'wait' for a container
to exit. Let's see if this fixes the flake.
And, while poking through flake logs, I found another missing wait.
And... in wait_for_output(), address a potential race.
Signed-off-by: Ed Santiago [email protected]