kube play: update the handling of PersistentVolumeClaim

[ygalblum]

Up - do not fail if volume already exists, use the existing one
Down - allow the user to remove the volume by passing --force
Add tests

Signed-off-by: Ygal Blum [email protected]

Does this PR introduce a user-facing change?

kube play: update the handling of PersistentVolumeClaim - reuse existing volumes and allow their removal with down

Resolves #16348

[vrothberg]

Code LGTM.

Are you intending to use that in the podman-kube@ template? If so, we need to massage that a bit I guess. kube play --replace does not remove volumes. It may be worth adding a StartPre directive using kube down.

[vrothberg]

@baude @mheon PTAL

[mheon]

Bunch of little things, overall looks fine

[rhatdan]

@umohnani8 PTAL

[umohnani8]

code LGTM

[rhatdan]

/approve
/lgtm
/hold

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, ygalblum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

/hold cancel

[baude]

/cherry-pick v4.3

[openshift-cherrypick-robot]

@baude: #16420 failed to apply on top of branch "v4.3":

Applying: kube play: update the handling of PersistentVolumeClaim
Using index info to reconstruct a base tree...
M	docs/source/markdown/podman-kube-play.1.md.in
M	pkg/api/handlers/libpod/kube.go
M	pkg/api/server/register_kube.go
M	pkg/bindings/kube/kube.go
M	pkg/bindings/kube/types.go
M	pkg/domain/entities/play.go
M	pkg/domain/infra/abi/play.go
A	pkg/domain/infra/tunnel/kube.go
M	test/e2e/play_kube_test.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/play_kube_test.go
Auto-merging pkg/domain/infra/tunnel/generate.go
CONFLICT (content): Merge conflict in pkg/domain/infra/tunnel/generate.go
Auto-merging pkg/domain/infra/abi/play.go
Auto-merging pkg/domain/entities/play.go
CONFLICT (content): Merge conflict in pkg/domain/entities/play.go
Auto-merging pkg/bindings/kube/types.go
CONFLICT (content): Merge conflict in pkg/bindings/kube/types.go
Auto-merging pkg/bindings/kube/kube.go
Auto-merging pkg/api/server/register_kube.go
Auto-merging pkg/api/handlers/libpod/kube.go
Auto-merging docs/source/markdown/podman-kube-play.1.md.in
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 kube play: update the handling of PersistentVolumeClaim
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick v4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.