Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compat build API returning two JSON objects at once #16418

Merged
merged 2 commits into from
Nov 7, 2022

Conversation

jakegt1
Copy link
Contributor

@jakegt1 jakegt1 commented Nov 5, 2022

Does this PR introduce a user-facing change?

Fix bug where if using compat API to build an image, reading the chunked response may include more JSON objects than expected per chunk.

Signed-off-by: Jake Torrance [email protected]

Closes #16360

@github-actions github-actions bot added the kind/api-change Change to remote API; merits scrutiny label Nov 5, 2022
@jakegt1 jakegt1 force-pushed the main branch 2 times, most recently from ca1afd8 to 7b0d2e7 Compare November 5, 2022 15:48
@rhatdan
Copy link
Member

rhatdan commented Nov 6, 2022

LGTM

@mheon
Copy link
Member

mheon commented Nov 7, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakegt1, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2022
@openshift-merge-robot openshift-merge-robot merged commit 9e04bab into containers:main Nov 7, 2022
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Change to remote API; merits scrutiny lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Podman socket: Build API produces different results then Docker's Build API
4 participants