remove container/pod id file along with container/pod #16394
Merged
+52
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note
approved
edsantiago
reviewed
Nov 3, 2022
rhatdan
reviewed
Nov 3, 2022
rhatdan
reviewed
Nov 3, 2022
rhatdan
reviewed
Nov 3, 2022
rhatdan
reviewed
Nov 3, 2022
vrothberg
force-pushed
the
fix-16387
branch
2 times, most recently
from
a88c253 to
16ad353
Compare
mheon
reviewed
Nov 3, 2022
Remove the container/pod ID file along with the container/pod. It's primarily used in the context of systemd and are not useful nor needed once a container/pod has ceased to exist. Fixes: containers#16387 Signed-off-by: Valentin Rothberg <[email protected]>
|
LGTM |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
alexlarsson
added a commit
to alexlarsson/podman
that referenced
this pull request
Dec 5, 2022
Since containers#16394 was merged we now always delete the cid file if --replace=true was specified, so we can avoid this extra command being launched. [NO NEW TESTS NEEDED] Already tested in above PR. Signed-off-by: Alexander Larsson <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the container/pod ID file along with the container/pod. It's primarily used in the context of systemd and are not useful nor needed once a container/pod has ceased to exist.
Fixes: #16387
Signed-off-by: Valentin Rothberg [email protected]
Does this PR introduce a user-facing change?