Make rm faster #1639
Make rm faster #1639
Conversation
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
bot, retest this please |
| }) | ||
| } | ||
|
|
||
| deleteErrors := parallelExecuteWorkerPool(rt.NumCPU()*3, deleteFuncs) |
There was a problem hiding this comment.
I think we'd this "rt.NumCPU()*3" in another piece of code. If we'll need to change/adjust them in both places potentially, further emphasis on getting the 3 into a conf file.
There was a problem hiding this comment.
Maybe a global Podman flag for now - "--numworkers" or somesuch
There was a problem hiding this comment.
a global flag would work for me instead of a conf file entry.
There was a problem hiding this comment.
there probably needs to be a little bit of a heuristic function for this. Nothing too complicated; in fact, I've been taking notes along the way. Because the possible functions being called can differ, it makes sense. The relationship is between the task, number of CPUs, and number of parallel functions that need to be executed. At that time, I think it would also make sense for a --max-parallel jobs flag.
baude
force-pushed
the
pararm
branch
2 times, most recently
from
26f5d28 to
506cabd
Compare
|
ready for merge |
|
I'll merge, but we should get a flag in to control max worker count soon |
|
LGTM |
|
If you haven't already, could you make a jira card or libpod issue for the flag please? |
|
i did |
When doing rm, we now parallelize the actual conainter deletions so they can complete faster. This speeds up operations like rm -a. Signed-off-by: baude <[email protected]>
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
When doing rm, we now parallelize the actual conainter deletions so they
can complete faster. This speeds up operations like rm -a.
Signed-off-by: baude [email protected]