runtime: add check for valid pod systemd cgroup #16377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note-none
approved
We have upgrade tests in |
|
LGTM |
giuseppe
force-pushed
the
add-check-for-valid-pod-systemd-cgroup
branch
from
1cca756 to
4a79206
Compare
there is already the same check when using cgroupfs, but not when using the systemd cgroup backend. The check is needed to avoid a confusing error from the OCI runtime. Closes: containers#16376 Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
add-check-for-valid-pod-systemd-cgroup
branch
from
4a79206 to
cac4919
Compare
|
test added and the CI is green |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there is already the same check when using cgroupfs, but not when using the systemd cgroup backend. The check is needed to avoid a confusing error from the OCI runtime.
Closes: #16376
[NO NEW TESTS NEEDED] it needs a pod created with an old Podman version.
Signed-off-by: Giuseppe Scrivano [email protected]
Does this PR introduce a user-facing change?