[CI:DOCS] Fix documentation on read-only-tmpfs #16374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
do-not-merge/release-note-label-needed
|
@edsantiago PTAL |
edsantiago
approved these changes
Nov 1, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
edsantiago
reviewed
Nov 1, 2022
| This protects the container's image from modification. Read-only containers may | ||
| still need to write temporary data. The best way to handle this is to mount | ||
| tmpfs directories on _/run_ and _/tmp_. | ||
| This protects the container's image from modification. By default read-only containers can write to temporary data. Podman mounts a tmpfs on /run and /tmp within the container. If the container should not write to any file system within the container, including tmpfs, set --read-only-tmpfs=false. |
There was a problem hiding this comment.
On second thought, though, you might want to backtick the paths, and asteriskize the option.
Signed-off-by: Daniel J Walsh <[email protected]>
|
LGTM, but documentation-focused reviewers may still want the double asterisks on the |
|
@TomSweeneyRedHat PTAL |
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel J Walsh [email protected]
Does this PR introduce a user-facing change?