fix connection usage with containers.conf #16328
Merged
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
do-not-merge/release-note-label-needed
|
Tests are failing. |
Luap99
reviewed
Oct 28, 2022
cdoern
force-pushed
the
config
branch
2 times, most recently
from
764a04f to
e893680
Compare
|
LGTM, but tests are unhappy |
|
friendly ping |
|
Sorry will fix today |
|
/lgtm |
openshift-ci
bot
added
do-not-merge/hold
|
no idea why these tests are failing, could be a registry issue? |
|
/approve |
openshift-ci
bot
added
the
approved
|
@cdoern Rebase and retry ,I fixed the apline search issue. |
|
LGTM |
--connection was failing due to the servicedestinations array being empty on runtime. Fix by making sure the cached config is used resolves containers#16282 Signed-off-by: Charlie Doern <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdoern, rhatdan, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--connection was failing due to the servicedestinations array being empty on runtime. Fix by making sure the cached config is used and properly given to the empty config.
resolves #16282
Signed-off-by: Charlie Doern [email protected]
Does this PR introduce a user-facing change?