Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sig-proxy test: bump timeout #16287

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

vrothberg
Copy link
Member

Bump the timeout waiting for the container to process the signal. The comparatively short timeout is most likely responsible for flakes in gating tests.

Fixes: #16091
Signed-off-by: Valentin Rothberg [email protected]

Does this PR introduce a user-facing change?

None

Bump the timeout waiting for the container to process the signal.
The comparatively short timeout is most likely responsible for
flakes in gating tests.

Fixes: containers#16091
Signed-off-by: Valentin Rothberg <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2022
@edsantiago
Copy link
Member

I don't think of five seconds as a "short timeout" for handling a signal... but, shrug, LGTM if there's no other option.

@vrothberg
Copy link
Member Author

@edsantiago wasn't it 2.5 seconds of timeout before and now we're at 5? Some other timeouts are at 10.

@edsantiago
Copy link
Member

Ugh, good point: $timeout is in half-seconds; I missed that.

The thing that bothers me is that this is a new test dating to Sept 20 (#15131). And it relies on podman logs, which is known to be unreliable (#16132, which, granted, is podman-remote). I'm OK with bumping this timeout, but I will keep a close eye on future flakes here.

@rhatdan
Copy link
Member

rhatdan commented Oct 25, 2022

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 25, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2022
@edsantiago
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 25, 2022
@vrothberg
Copy link
Member Author

I'm OK with bumping this timeout, but I will keep a close eye on future flakes here.

Thanks for keeping an eye on these flakes! Bumping timeouts never gives me a satisfying feeling (or accomplishment) but that is the best "guess" I have for this flake.

@openshift-merge-robot openshift-merge-robot merged commit 589ff20 into containers:main Oct 25, 2022
@lsm5
Copy link
Member

lsm5 commented Nov 15, 2022

/cherrypick v4.3

@openshift-cherrypick-robot
Copy link
Collaborator

@lsm5: new pull request created: #16516

In response to this:

/cherrypick v4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

signal flake: Timed out waiting for BYE
6 participants