Only read containers.conf once. #16242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rhatdan: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
do-not-merge/release-note-label-needed
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
github-actions
bot
added
the
kind/api-change
mheon
reviewed
Oct 20, 2022
libpod/runtime.go
Outdated
| @@ -1169,3 +1169,8 @@ func (r *Runtime) RemoteURI() string { | |||
| func (r *Runtime) SetRemoteURI(uri string) { | |||
| r.config.Engine.RemoteURI = uri | |||
| } | |||
|
|
|||
| // SetRemoteURI records the API server URI | |||
rhatdan
force-pushed
the
config
branch
2 times, most recently
from
a959f88 to
a0e2df2
Compare
We should not be changing these fields on the client side unless the user specified them. This patch drops strace mentions of containers.conf from 116 down to 26. Fixes: containers/common#1200 [NO NEW TESTS NEEDED] Existing tests should test this. Signed-off-by: Daniel J Walsh <[email protected]>
|
Closing in favor of #16238 |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not be changing these fields on the client side unless the user specified them.
This patch drops strace mentions of containers.conf from 116 down to 26.
Fixes: containers/common#1200
[NO NEW TESTS NEEDED] Existing tests should test this.
Signed-off-by: Daniel J Walsh [email protected]
Does this PR introduce a user-facing change?