Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: Vendor unmerged https://github.com/containers/storage/pull/1399 #16222

Closed
wants to merge 1 commit into from

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Oct 18, 2022

Does this PR introduce a user-facing change?

None

@mtrmac mtrmac marked this pull request as draft October 18, 2022 23:25
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 18, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtrmac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2022
@mtrmac mtrmac force-pushed the locking-test branch 3 times, most recently from b9b8640 to 873fe9e Compare October 19, 2022 02:38
DO NOT MERGE: Vendor containers/buildah#4350

Remove uses of Lockfile.Locked():
One of them is entirely unnecessary, and the other one
is avoidable.

[NO NEW TESTS NEEDED]

Signed-off-by: Miloslav Trmač <[email protected]>
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 30, 2022
@openshift-merge-robot
Copy link
Collaborator

@mtrmac: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mtrmac
Copy link
Collaborator Author

mtrmac commented Nov 1, 2022

containers/storage#1399 was merged, and included by #16202.

@mtrmac mtrmac closed this Nov 1, 2022
@mtrmac mtrmac deleted the locking-test branch November 1, 2022 01:47
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants