Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference #16207

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Reference #16207

merged 1 commit into from
Oct 17, 2022

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Oct 17, 2022

containers/image/v5/docker/reference has same content, but
less overhead.

Partial fix for: #16205

Signed-off-by: Daniel J Walsh [email protected]

Does this PR introduce a user-facing change?

None

[NO NEW TESTS NEEDED]

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2022
@github-actions github-actions bot added the kind/api-change Change to remote API; merits scrutiny label Oct 17, 2022
containers/image/v5/docker/reference has same content, but
less overhead.

Partial fix for: containers#16205

Signed-off-by: Daniel J Walsh <[email protected]>
@rhatdan
Copy link
Member Author

rhatdan commented Oct 17, 2022

@alexlarsson @vrothberg @mtrmac PTAL

Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

yes please.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2022
@rhatdan
Copy link
Member Author

rhatdan commented Oct 17, 2022

@mtrmac "github.com/docker/distribution/registry/api/v2" is pulling in github.com/docker/distribution/reference which is pulling in github.com/docker/distribution/digestset

@mtrmac
Copy link
Collaborator

mtrmac commented Oct 17, 2022

Yes. We could plausibly get rid of that one, but another way docker/distribution/reference is pulled in is via docker/docker/client, which we can’t get rid of as easily.

@openshift-merge-robot openshift-merge-robot merged commit 2fb7218 into containers:main Oct 17, 2022
@rhatdan rhatdan deleted the reference branch December 1, 2022 22:00
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Change to remote API; merits scrutiny lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants