Add --quiet and --no-info flags to podman machine start

[ashley-cui]

Add quiet and no-info flags to podman machine start.
No-info suppresses helpful informational tips
Quiet suppresses machine start progress output, as well as informational
tips.
Signed-off-by: Ashley Cui [email protected]

Closes: #15525

Does this PR introduce a user-facing change?

Add quiet and no-info flags to podman machine start

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashley-cui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ashley-cui]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ashley-cui]

Probably need someone to test this on Windows.

[Luap99]

Do we really need to flags for that? Also there is already a podman --noout flag

[ashley-cui]

@Luap99 --noout does not suppress machine commands output. There was a community request for the behavior of the --no-info flag (#15525), and I thought I'd add the -q while I was at it.

[mheon]

Wait, --noout doesn't work? That should work for everything - if it doesn't we should be fixing --noout.

I don't object to adding --quiet or similar, but we also have to make sure --noout does not print anything.

[ashley-cui]

@mheon Sure, I'll open an issue for fixing --noout for podman machine

[rhatdan]

Does that mean we no longer need this PR?

[ashley-cui]

I'd argue the initial request (which is the --no-info flag in this pr) does something different than --noout since it only suppresses helpful tips and not start status, but I'm open to changing my mind

[rhatdan]

Wouldn't piping to grep also do that?

[ashley-cui]

I don't think so, since we don't label info lines, they're just printed? So there's no pattern to match necessarily?

[rhatdan]

Can you remove the --quiet option since this seems to duplicate --noout and then make --noout work.

[vrothberg]

friendly ping

[rhatdan]

LGTM
@vrothberg PTAL

[vrothberg]

Apologies, I should have checked that before the ping. What's the reasoning for not using -q/--quiet? I don't see any flags yet for machine start and -q is used conventionally across so many tools.

[TomSweeneyRedHat]

Changes LGTM, but like @vrothberg , I'd much prefer -q / --quiet unless there's a strong reason not to.

[ashley-cui]

--quiet is back :)

[rhatdan]

My understanding would be people want --quiet to also mean --no-info, IE Drop --no-info.

[ashley-cui]

I feel like --quiet means that it suppresses all status output, whereas no-info only surpasses troubleshooting tips. I feel like they serve different purposes.

[vrothberg]

I feel like --quiet means that it suppresses all status output, whereas no-info only surpasses troubleshooting tips. I feel like they serve different purposes.

I think that's fair.

[rhatdan]

What value does --no-output serve which would not be serve by
$ podman machine ... |grep -v

IE Why complicate things. We should only output stuff that is important to the user, if the output is not important then it should be logrus.Info or Debug and not output at all.

If user does not want output the --quiet should suffice and they can check the exit code.

[ashley-cui]

The troubleshooting tips are there because they ended up being common questions/configurations that pop up. I still feel like each flag have different purposes. Here are the differences:

No flags output:
This prints machine starting status as well as tips on common places where podman may fail.

$ podman machine start
Starting machine "podman-machine-default"
Waiting for VM ...
Mounting volume... /Users/pellcorp:/Users/pellcorp

This machine is currently configured in rootless mode. If your containers
require root permissions (e.g. ports < 1024), or if you run into compatibility
issues with non-podman clients, you can switch using the following command: 

	podman machine set --rootful

API forwarding listening on: /Users/pellcorp/.local/share/containers/podman/machine/podman-machine-default/podman.sock

The system helper service is not installed; the default Docker API socket
address can't be used by podman. If you would like to install it run the
following commands:

	sudo /opt/homebrew/Cellar/podman/4.2.0/bin/podman-mac-helper install
	podman machine stop; podman machine start

You can still connect Docker API clients by setting DOCKER_HOST using the
following command in your terminal session:

	export DOCKER_HOST='unix:///Users/pellcorp/.local/share/containers/podman/machine/podman-machine-default/podman.sock'

Machine "podman-machine-default" started successfully

No info flag (this was the specfic behavior asked for in the issue)
This still prints status updates on the machine but does not remind the user about other configs

$ podman machine --no-info start
Starting machine "podman-machine-default"
Waiting for VM ...
Mounting volume... /Users/pellcorp:/Users/pellcorp
Machine "podman-machine-default" started successfully

Quiet:

$ podman machine -q start
Machine "podman-machine-default" started successfully

--noout

$ podman --noout machine  start

I still feel like the suppressed information on each (troubleshooting vs start status) is unique enough to warrant two flags.

[vrothberg]

I agree with @ashley-cui in this case. Exceptions confirm the rule :^)

[rhatdan]

I would argue that:

Starting machine "podman-machine-default"
Waiting for VM ...
Mounting volume... /Users/pellcorp:/Users/pellcorp
Machine "podman-machine-default" started successfully

Is info.
But fine, if you two want this, fine.

[vrothberg]

I agree with both of you :-) Not sure that helps. How about you bring this up during Cabal? I won´t be able to join but you already know I like everything.

[ashley-cui]

Ready to go! :)

[rhatdan]

/lgtm