libpod: Factor out the call to PidFdOpen from (*Container).WaitForExit #16182
Conversation
|
@alexlarsson PTAL |
This allows us to add a simple stub for FreeBSD which returns -1, leading WaitForExit to fall back to the sleep loop approach. [NO NEW TESTS NEEDED] Signed-off-by: Doug Rabson <[email protected]>
|
We need to get a freebsd cross compiler working... |
openshift-ci
bot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dfr, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
My preferred solution would be to get godbus/dbus#332 merged but I'm getting zero feedback - that repo seems to be almost unmaintained. The dbus stuff is needed by systemd - I spent some time trying to avoid systemd in the FreeBSD build but only succeeded in making a big mess which still didn't build. Fixing dbus to build with cgo does allow a clean cross build. |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
This allows us to add a simple stub for FreeBSD which returns -1, leading WaitForExit to fall back to the sleep loop approach.
Signed-off-by: Doug Rabson [email protected]
Does this PR introduce a user-facing change?