[wip] libpod: propogate custom DNS server to /etc/resolv.conf only when dns_enabled for network
#16175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
flouthoc
force-pushed
the
docker-parity-resolv-conf
branch
from
aeb2e05 to
1eba972
Compare
flouthoc
force-pushed
the
docker-parity-resolv-conf
branch
3 times, most recently
from
1dab847 to
91f2ab3
Compare
|
Since aardvark has no support for custom dns right now we should not change this. Only when this feature is implemented we can switch this |
flouthoc
force-pushed
the
docker-parity-resolv-conf
branch
from
91f2ab3 to
4de1323
Compare
That's fair we can get this in at last when entire feature is implemented. |
flouthoc
force-pushed
the
docker-parity-resolv-conf
branch
from
4de1323 to
54d79e2
Compare
…_enabled Podman populates container's `/etc/resolv.conf` with custom DNS servers ( specified via `--dns` or `dns_server` in containers.conf ) even when container is connected to a network where `dns_enabled` is `true`. Current behavior does not matches with docker, hence following commit ensures that podman only populates custom DNS server when container is not connected to any network where DNS is enabled and for the cases where `dns_enabled` is `true` the resolution for custom DNS server will happen via ( `aardvark-dns` or `dnsname` ). Reference: https://docs.docker.com/config/containers/container-networking/#dns-services Closes: containers#16172 ```release-note container: `--dns` and `dns_server` behavior for containers connected to network matches with docker now ``` Signed-off-by: Aditya R <[email protected]>
flouthoc
force-pushed
the
docker-parity-resolv-conf
branch
from
54d79e2 to
01915ad
Compare
rhatdan
changed the title
/etc/resolv.conf only when dns_enabled for network/etc/resolv.conf only when dns_enabled for network
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Moving to WIP until the aardvark fix is in place. |
|
Closing in favor of: #16297 |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Podman populates container's
/etc/resolv.confwith custom DNS servers ( specified via--dnsordns_serverin containers.conf ) even when container is connected to a network wheredns_enabledistrue.Current behavior does not matches with docker, hence following commit ensures that podman only populates custom DNS server when container is not connected to any network where DNS is enabled and for the cases where
dns_enabledistruethe resolution for custom DNS server will happen via (
aardvark-dnsordnsname).Reference: https://docs.docker.com/config/containers/container-networking/#dns-services
Closes: #16172