increase timeout of on-failure=kill system test #16112
Conversation
The on-failure=kill system tests turned out to be flaky. Once the container has been killed, the test waits for systemd to restart the service by running `container inspect` for 10 seconds. The subsequent `healthcheck run` was the flake point which suggests the 10 seconds timeout to not be sufficiently high enough; presumably when the CI nodes are under pressure. Fixes: containers#16075 Signed-off-by: Valentin Rothberg <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@edsantiago WDYT? |
|
I'm not usually a fan of bumping timeouts. Is there another check that can be done to at least verify intermediate progress? I'm OOTO today, will not be able to look again, but will check first thing Wednesday morning. |
I tried coming up with an alternative approach but could not find one. What we are waiting for essentially is for the container to be recreated and started. |
|
LGTM |
|
@vrothberg can we go with #16129, if you agree with my fix? |
github-actions
bot
added
the
locked - please file new issue/PR
The on-failure=kill system tests turned out to be flaky. Once the container has been killed, the test waits for systemd to restart the service by running
container inspectfor 10 seconds. The subsequenthealthcheck runwas the flake point which suggests the 10 seconds timeout to not be sufficiently high enough; presumably when the CI nodes are under pressure.Fixes: #16075
Signed-off-by: Valentin Rothberg [email protected]
Does this PR introduce a user-facing change?