health checks: make on-failure action retry aware #16084
Merged
+30
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
vrothberg
force-pushed
the
health-check-fix
branch
from
7135003 to
5c99afd
Compare
|
LGTM |
Luap99
reviewed
Oct 7, 2022
vrothberg
force-pushed
the
health-check-fix
branch
from
5c99afd to
07f2fdc
Compare
Make sure that the on-failure actions only kick in once the health check has passed its retries. Also fix race conditions on reading/writing the log. Signed-off-by: Valentin Rothberg <[email protected]>
vrothberg
force-pushed
the
health-check-fix
branch
from
07f2fdc to
0204008
Compare
|
LGTM |
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
This was referenced Oct 7, 2022
openshift-merge-robot
added a commit
that referenced
this pull request
Oct 9, 2022
[v4.2.0-rhel] Backport #16084
openshift-merge-robot
added a commit
that referenced
this pull request
Oct 10, 2022
[v4.1.1-rhel] Backported #16084 to v4.1.1-rhel
|
Follow up fix for https://bugzilla.redhat.com/show_bug.cgi?id=2097708 |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that the on-failure actions only kick in once the health check has passed its retries.
Signed-off-by: Valentin Rothberg [email protected]
Does this PR introduce a user-facing change?
@mheon PTAL