Add support for 'podman pod' on FreeBSD #16083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the cgroup code to pod_internal_linux.go and adds a no-op stub for FreeBSD. [NO NEW TESTS NEEDED] Signed-off-by: Doug Rabson <[email protected]>
The value of p.PodSpecGen.InfraContainerSpec.ResourceLimits can be nil on FreeBSD. [NO NEW TESTS NEEDED] Signed-off-by: Doug Rabson <[email protected]>
Most of the code can be shared with other unix-like platforms. [NO NEW TESTS NEEDED] Signed-off-by: Doug Rabson <[email protected]>
This moves the code to runtime_pod_linux.go since cgroups are platform-specific. [NO NEW TESTS NEEDED] Signed-off-by: Doug Rabson <[email protected]>
[NO NEW TESTS NEEDED] Signed-off-by: Doug Rabson <[email protected]>
|
/approve |
|
@containers/podman-maintainers PTAL |
openshift-ci
bot
added
the
approved
|
/lgtm Today I discovered |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dfr, giuseppe, mheon, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
baude
added a commit
to baude/podman
that referenced
this pull request
Oct 11, 2022
PR containers#16083 breaks pod creation [NO NEW TESTS NEEDED] Signed-off-by: Brent Baude <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is fairly straightforward, mainly moving cgroup management out of the common code.
Does this PR introduce a user-facing change?