Revert "cmd/podman: add support for checkpoint images" #16078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note-none
approved
|
@rst0git I think we need to revert this merge and rework it on the server side not on the client side. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan, rst0git The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Tests are very red |
This reverts commit 9c3d8bb. Signed-off-by: Daniel J Walsh <[email protected]>
|
@rhatdan Github is complaining about a DCO? |
This reverts commit bbe1063. Signed-off-by: Daniel J Walsh <[email protected]>
edsantiago
reviewed
Oct 13, 2022
| @@ -233,7 +233,7 @@ Pods removed: | |||
| `podman kube play --down` will not work with a URL if the YAML file the URL points to | |||
| has been changed or altered. | |||
|
|
|||
|
|
|||
| @@option tls-verify | |||
There was a problem hiding this comment.
@rhatdan do you have any idea why you added this here? It's weird and out of place, I'm 99.99% sure it's an oops. I am going to remove it in my upcoming include-mechanism PR.
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 9c3d8bb.
This patch needs to be reworked to happen on the server side not on the client side.
Replaces #16068
Does this PR introduce a user-facing change?
[NO NEW TESTS NEEDED]