libpod: Remove 100msec delay during shutdown #16072
Conversation
|
@alexlarsson: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
do-not-merge/release-note-label-needed
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexlarsson, giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
rhatdan
removed
the
do-not-merge/release-note-label-needed
|
LGTM |
|
LGTM. Restarted two test failures which looked like flakes. |
|
/lgtm |
openshift-ci
bot
added
do-not-merge/hold
|
System test failures look real |
|
agree |
|
Indeed, with this patch, |
alexlarsson
force-pushed
the
events-shutdown-nosleep
branch
from
8163d8f to
600893f
Compare
|
So, the issue was that we were indeed handling the remaining events before exiting the eventloop goroutine. However, the shutdown side only blocked until the eventloop read the shutdown event, not until it finished the eventloop iteration. I fixed this by adding a second synchronization step on the close of the shutdown channel. So, we send the shutdown event, then block on the channel closing (which happens on exit from the eventloop now). |
When shutting down the image engine we always wait for the image even goroutine to finish writing any outstanding events. However, the loop for that always waits 100msec every iteration. This means that (depending on the phase) shutdown is always delayed up to 100msec. This is delaying "podman run" extra much because podman is run twice (once for the run and once as cleanup via a conmon callback). Changing the image loop to exit immediately when a libimageEventsShutdown (but first checking for any outstanding events to write) improves podman run times by about 100msec on average. Note: We can't just block on the event loop reading the shutdown event anymore, we need to wait until it read and processed any outstanding events, so we now send the shutdown event and then block waiting for the channel to be closed by the event loop. [NO NEW TESTS NEEDED] Signed-off-by: Alexander Larsson <[email protected]>
alexlarsson
force-pushed
the
events-shutdown-nosleep
branch
from
600893f to
5b71070
Compare
|
/lgtm |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
When shutting down the image engine we always wait for the image even goroutine to finish writing any outstanding events. However, the loop for that always waits 100msec every iteration. This means that (depending on the phase) shutdown is always delayed up to 100msec.
This is delaying "podman run" extra much because podman is run twice (once for the run and once as cleanup via a conmon callback).
Changing the image loop to exit immediately when a libimageEventsShutdown (but first checking for any outstanding events to write) improves podman run times by about 100msec on average.
[NO NEW TESTS NEEDED]
Signed-off-by: Alexander Larsson [email protected]