Create a full path to a directory when DirectoryOrCreate is used #16067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luap99
reviewed
Oct 6, 2022
pkg/specgen/generate/kube/volume.go
Outdated
| @@ -57,7 +57,7 @@ func VolumeFromHostPath(hostPath *v1.HostPathVolumeSource) (*KubeVolume, error) | |||
| switch *hostPath.Type { | |||
| case v1.HostPathDirectoryOrCreate: | |||
| if _, err := os.Stat(hostPath.Path); os.IsNotExist(err) { | |||
There was a problem hiding this comment.
Remove the Stat here, MkdirAll will already calls stat anyway
There was a problem hiding this comment.
Done (and new test has been added)
…lay kube Signed-off-by: Mikhail Khachayants <[email protected]>
tyler92
force-pushed
the
fix-directory-or-create
branch
from
c1dc114 to
8b189c0
Compare
Luap99
approved these changes
Oct 6, 2022
openshift-ci
bot
added
the
approved
|
/lgtm |
openshift-ci
bot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, mheon, tyler92 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider empty directory /root and the following piece of Pod yaml:
Podman failed to play such Kube with error:
k8s sources: one, two
Signed-off-by: Mikhail Khachayants [email protected]
Does this PR introduce a user-facing change?