Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump golangci-lint to v1.49.0 #16011

Merged
merged 1 commit into from
Oct 17, 2022
Merged

bump golangci-lint to v1.49.0 #16011

merged 1 commit into from
Oct 17, 2022

Conversation

vrothberg
Copy link
Member

Motivated to have a working make lint on Fedora 37 (beta). Most changes come from the new gofmt standards.

Signed-off-by: Valentin Rothberg [email protected]

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 30, 2022
@github-actions github-actions bot added the kind/api-change Change to remote API; merits scrutiny label Sep 30, 2022
@mheon
Copy link
Member

mheon commented Sep 30, 2022

I am not a fan of whatever linter is requesting comment changes.

The rest seems perfectly fine.

@vrothberg
Copy link
Member Author

I am not a fan of whatever linter is requesting comment changes.

It's gofmt actually - Go 1.19 updated how comments are formatted. There's not much we can do I guess.

I probably won't find time to push this over the finish line before my PTO. Feel free to pick this up if needed.

mtrmac
mtrmac reviewed Oct 13, 2022
View reviewed changes
libpod/lock/shm/shm_lock.go Outdated Show resolved Hide resolved
@Luap99 Luap99 mentioned this pull request Oct 14, 2022
Merged
@vrothberg
bump golangci-lint to v1.49.0
44bac51 
Motivated to have a working `make lint` on Fedora 37 (beta).
Most changes come from the new `gofmt` standards.

Signed-off-by: Valentin Rothberg <[email protected]>
@vrothberg
Copy link
Member Author

Thanks, @cevich, for the quick turnaround on the swagger issue!

@containers/podman-maintainers PTAL

Luap99
Luap99 reviewed Oct 17, 2022
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

flouthoc
flouthoc approved these changes Oct 17, 2022
View reviewed changes
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrothberg
Copy link
Member Author

merge me

@flouthoc
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2022
@openshift-merge-robot openshift-merge-robot merged commit cd0c949 into containers:main Oct 17, 2022
@vrothberg vrothberg deleted the lint branch October 17, 2022 10:33
@edsantiago edsantiago mentioned this pull request Oct 19, 2022
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Luap99 Luap99 Luap99 left review comments

@mheon mheon mheon left review comments

@mtrmac mtrmac mtrmac left review comments

@cevich cevich cevich left review comments

@flouthoc flouthoc flouthoc approved these changes

Assignees

@flouthoc flouthoc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Change to remote API; merits scrutiny lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vrothberg @mheon @flouthoc @cevich @mtrmac @Luap99 @openshift-merge-robot