fix "podman system prune networks" flake

[Luap99]

Since by default the network config dir is shared in the e2e tests any
other parallel running test could remove a network and cause this test to
fail.

Fixes #15990

Does this PR introduce a user-facing change?

None

[Luap99]

@edsantiago PTAL

[edsantiago]

Nice catch. Thank you for the quick work.

[rhatdan]

/approve
/lgtm
/hold

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, Luap99, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Luap99,edsantiago,rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mheon]

Restarted one flake, changes LGTM

[edsantiago]

I got to thinking: it takes two to tango, no? If this test is failing because some other test is stepping on it, shouldn't we see failures in that other test too? And shouldn't that other test be fixed? Unfortunately I can't find any clear indications in my flake logs, and I tried reading the test code, and that didn't go so well. Anyhow, just wondering if there's another place in the tests where we need to do the tmpdir thing.

[Luap99]

I got to thinking: it takes two to tango, no? If this test is failing because some other test is stepping on it, shouldn't we see failures in that other test too? And shouldn't that other test be fixed? Unfortunately I can't find any clear indications in my flake logs, and I tried reading the test code, and that didn't go so well. Anyhow, just wondering if there's another place in the tests where we need to do the tmpdir thing.

The problem is that in that test file many test do podman system prune which also removes networks, the other test doesn't care if it removes more than it should. Generally speaking it may be more future proof if all system prune/reset tests would use their own network config dir to prevent causing failures in other network tests.

[edsantiago]

/hold cancel

thanks again