Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "remote: fix manifest add --annotation" #15992

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Sep 29, 2022

This reverts commit 32f54a8.

pkg/bindings is supported outside of podman and we have to keep it stable.

Does this PR introduce a user-facing change?

None

This reverts commit 32f54a8.

`pkg/bindings` is supported outside of podman and we have to keep it
stable.

Signed-off-by: Paul Holzinger <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2022
@github-actions github-actions bot added the kind/api-change Change to remote API; merits scrutiny label Sep 29, 2022
@Luap99
Copy link
Member Author

Luap99 commented Sep 29, 2022

We have to reopen #15952 once this is merged

@vrothberg
Copy link
Member

I'd argue that fixing the issues is probably better than reverting but given we cut v4.3, let's better play it safe and revert to prevent releasing the changes.

LGTM

@mheon
Copy link
Member

mheon commented Sep 29, 2022

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 29, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2022
@edsantiago
Copy link
Member

Oh, how nice, the api-change label bot is triggering.

@vrothberg
Copy link
Member

Oh, how nice, the api-change label bot is triggering.

I changed the label color to red. That'll hopefully catch my attention next time.

@edsantiago
Copy link
Member

I disagree pretty strongly about that: there is way, way too much red in the labels already, I firmly believe that another red is just going to be ignored even more. I deliberately set the color to an orange-yellow because that's still a danger signal to human eyes, and it's a color that is not otherwise used in the labels.

I will not undo your change, though. I am just pointing out a human-factors problem, will leave for others to discuss and fix.

@vrothberg
Copy link
Member

Apologies, Ed. I didn't know the yellow/orange was deliberate. To me/on my screen, it looks yellow which does not indicate any danger to me.

@edsantiago
Copy link
Member

No apology needed - I clearly chose poor colors. (I am not a UI expert). Someone with better UI skills should look into this.

@rhatdan
Copy link
Member

rhatdan commented Sep 29, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 29, 2022
@openshift-merge-robot openshift-merge-robot merged commit 4c39b39 into containers:main Sep 29, 2022
@Luap99 Luap99 deleted the revert-15988 branch September 29, 2022 14:51
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Change to remote API; merits scrutiny lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants