-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "remote: fix manifest add --annotation" #15992
Conversation
This reverts commit 32f54a8. `pkg/bindings` is supported outside of podman and we have to keep it stable. Signed-off-by: Paul Holzinger <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We have to reopen #15952 once this is merged |
I'd argue that fixing the issues is probably better than reverting but given we cut v4.3, let's better play it safe and revert to prevent releasing the changes. LGTM |
/lgtm |
Oh, how nice, the |
I changed the label color to red. That'll hopefully catch my attention next time. |
I disagree pretty strongly about that: there is way, way too much red in the labels already, I firmly believe that another red is just going to be ignored even more. I deliberately set the color to an orange-yellow because that's still a danger signal to human eyes, and it's a color that is not otherwise used in the labels. I will not undo your change, though. I am just pointing out a human-factors problem, will leave for others to discuss and fix. |
Apologies, Ed. I didn't know the yellow/orange was deliberate. To me/on my screen, it looks yellow which does not indicate any danger to me. |
No apology needed - I clearly chose poor colors. (I am not a UI expert). Someone with better UI skills should look into this. |
/hold cancel |
This reverts commit 32f54a8.
pkg/bindings
is supported outside of podman and we have to keep it stable.Does this PR introduce a user-facing change?