Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: liveness check with http probe #15958

Merged
merged 1 commit into from
Sep 27, 2022
Merged

fix: liveness check with http probe #15958

merged 1 commit into from
Sep 27, 2022

Conversation

piotr-sk
Copy link
Contributor

@piotr-sk piotr-sk commented Sep 27, 2022

  • When a pod with HTTP liveness probe is created using podman kube play, ensure the Kubernetes defaults values are respected.
  • Additional curl parameter enforces returning error for HTTP error codes.
  • Uses build-in HealthCheckOnFailureAction instead of killing the container while executing the probe.

Fixes #15855

Does this PR introduce a user-facing change?

None

@mheon
Copy link
Member

mheon commented Sep 27, 2022

/approve
LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon, piotr-sk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2022
Ensure kubernetes default parameters are respected.
Additional curl parameter enforces returning error for HTTP error codes.
Use build-in HealthCheckOnFailureAction instead of killing the container
while executing the probe.

Signed-off-by: Piotr <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Sep 27, 2022

Thanks @piotr-sk
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2022
@openshift-merge-robot openshift-merge-robot merged commit a225cb5 into containers:main Sep 27, 2022
@piotr-sk piotr-sk deleted the fix/kube_play_liveness_probe branch September 27, 2022 19:48
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

play kube liveness HTTP probe does not use defaults
4 participants