Update vendor of containers(image, common, buildah, storage) #15900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note
approved
rhatdan
force-pushed
the
VENDOR
branch
4 times, most recently
from
fd24b89 to
66d460b
Compare
|
LGTM |
github-actions
bot
added
the
kind/api-change
edsantiago
reviewed
Sep 22, 2022
cmd/podman/images/build.go
Outdated
|
|
||
| if cmd.Flag("network").Changed { | ||
| if buildOpts.Network != "host" && buildOpts.Isolation == buildahDefine.IsolationChroot.String() { | ||
| return fmt.Errorf("cannot set --network %s --isolation %s", buildOpts.Network, buildOpts.Isolation) |
There was a problem hiding this comment.
Inconsistent with buildah:
# #| expected: =~ 'cannot set --network other than host with --isolation chroot'
# #| actual: 'Error: cannot set --network none --isolation chroot'
There was a problem hiding this comment.
FYI options are change the message, skip the test (see treadmill PR), or use the errmsg directive in apply-whatever to change the expected error message. I think changing the podman error message is the easiest, but I don't have all the facts.
rhatdan
force-pushed
the
VENDOR
branch
3 times, most recently
from
3c84ac8 to
1575f0e
Compare
Signed-off-by: Daniel J Walsh <[email protected]>
Changes since 2022-09-09: - man page: add --skip-unused-stages (buildah 4249) - man page: bring in new Note for --cache-ttl (4248) - system tests: de-stutter (4205) - (internal): in skip() applier: escape asterisk, otherwise the "bud with --dns* flags" sed expression never applies. Signed-off-by: Ed Santiago <[email protected]> Signed-off-by: Daniel J Walsh <[email protected]>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdoern, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR introduce a user-facing change?