CI: only make install.tools when needed

[edsantiago]

Reintroduce .install.foo targets into Makefile, and invoke
only the bare-minimum ones needed for each individual CI
step in setup_environment.sh.

Also add a retry to the golangci-lint curl, in hopes of
dealing with network flakes. And remove the -f (fail)
because it produces unhelpful logs.

Reason: saw about 25% CI flakes yesterday due to the golangci-lint
fetch, something about a timeout, and this was especially frustrating
because none of the steps actually needed lint. Quick reminder:
avoid network fetches unless absolutely necessary.

Fixes: #15892

Signed-off-by: Ed Santiago [email protected]

None

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [edsantiago]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[edsantiago]

@cevich any idea what's going on with CI today? Seen in multiple in-flight PRs:

fatal: Not a valid commit name 2cae850cb869b0a8790400c5c830dd67e0a410ea

[cevich]

@cevich any idea what's going on with CI today? Seen in multiple in-flight PRs:

I'm pretty sure it's GitHub's fault, it's affecting everybody. Re-running doesn't seem to work (for who-knows-why), Waiting 5-10m and force-pushing a small change seems to un-stuck it most of the time. But if everybody does it, it may make the problem worse but IDK for sure.

[cevich]

Reintroduce .install.foo targets into Makefile, and invoke

FWIW, we perform this install at VM image build time, so maybe it's unnecessary at runtime? IIRC, the complaint was that makes it harder for developers to update, since it (formerly) required a new image build + Makefile update (here).

IMHO, installing stuff (in general) with make is asking for trouble, it's not the right tool. This is somewhat evidenced by all the .PHONY make targets that are used. That said, if these targets were to depend on and poke a file like $GOPATH/bin/.installed.foo.<version> maybe some redundant installs at runtime could be avoided (unless the version is updated)? Just a thought.

[cevich]

LGTM

[edsantiago]

IMHO, installing stuff (in general) with make is asking for trouble, it's not the right tool.

Agreed, and I also agree with finding a way to install these tools in the VMs, not at runtime. But that's a big can of worms, and my purpose here is to do something fast easy simple trivial to get rid of nasty flakes.

[cevich]

do something fast easy simple trivial to get rid of nasty flakes.

Yep, I gotcha, I wasn't calling for that here, just mentioning it since it keeps popping up for me. Seems like something that should go into a Cabal meeting and/or Jira card at the least.

[cevich]

Ugh...woops...brain-fart: There's a merge bot.