Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a few missed io/ioutil -> os updates #15890

Merged
merged 1 commit into from
Sep 21, 2022
Merged

Fix a few missed io/ioutil -> os updates #15890

merged 1 commit into from
Sep 21, 2022

Conversation

cevich
Copy link
Member

@cevich cevich commented Sep 21, 2022 •
edited
Loading

Somehow these crept in or were missed by my grep.

Ref: #15871

Fixes: #15889

Does this PR introduce a user-facing change?

Replace additional usage of io/ioutil (deprecated as of golang 1.16)

@cevich cevich mentioned this pull request Sep 21, 2022
Merged
rhatdan
rhatdan reviewed Sep 21, 2022
View reviewed changes
ioutil.sed Outdated Show resolved Hide resolved
ashley-cui
ashley-cui reviewed Sep 21, 2022
View reviewed changes
Copy link
Member

@ashley-cui ashley-cui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Luap99
Luap99 reviewed Sep 21, 2022
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Sep 21, 2022
@edsantiago edsantiago mentioned this pull request Sep 21, 2022
Merged
@edsantiago
Copy link
Member

/approve
/hold cancel

thank you @cevich!

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, edsantiago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2022
@openshift-merge-robot openshift-merge-robot merged commit ecaefee into containers:main Sep 21, 2022
@cevich cevich deleted the more_ioutil_fixes branch April 18, 2023 14:50
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Luap99 Luap99 Luap99 left review comments

@ashley-cui ashley-cui ashley-cui left review comments

@rhatdan rhatdan rhatdan left review comments

Assignees

@Luap99 Luap99

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI broken: lint, ioutil
6 participants
@cevich @edsantiago @rhatdan @ashley-cui @Luap99 @openshift-merge-robot