DO NOT MERGE: see how aarch64 is doing #15888
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
edsantiago
force-pushed
the
see_how_aarch64_is_doing
branch
from
fe8e34d to
30c7a08
Compare
A lot of system tests fail on aarch64, and are being skipped. Let's try disabling that skip, and see if they still fail. Signed-off-by: Ed Santiago <[email protected]>
edsantiago
force-pushed
the
see_how_aarch64_is_doing
branch
from
30c7a08 to
00d2435
Compare
|
Wowwww.... it passed! Re-running, because some of the past failures were flakes. |
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
Sep 21, 2022
Background: in order to add aarch64 tests, we had to add emergency skips to a lot of failing tests. No attempt was ever made to understand why they were failing. Fast forward to today, I filed containers#15888 just to see if tests are still failing. Looks like a number of them are fixed. (Yes, magically). Remove those skips. See: containers#15074, containers#15277 Signed-off-by: Ed Santiago <[email protected]>
|
I learned what I needed to learn. |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of system tests fail on aarch64, and are being skipped.
Let's try disabling that skip, and see if they still fail.
Signed-off-by: Ed Santiago [email protected]