Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman-save: Add signature-policy flag #15870

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

idleroamer
Copy link
Contributor

@idleroamer idleroamer commented Sep 20, 2022

Allow overwrite of the signature-policy file
similiar to other cli commands: podman load, podman pull, ...

Closes: #15869
Signed-off-by: 😎Mostafa Emami [email protected]

Does this PR introduce a user-facing change?

podman save supports `--signature-policy` flag

@mheon
Copy link
Member

mheon commented Sep 20, 2022

Any chance you can add a test?

@idleroamer idleroamer force-pushed the podman-save branch 6 times, most recently from 940f889 to d59c517 Compare September 21, 2022 14:27
Allow overwrite of the signature-policy file
by passing signature-policy flag to podman save command

Closes: containers#15869
Signed-off-by: 😎Mostafa Emami <[email protected]>
@idleroamer
Copy link
Contributor Author

Any chance you can add a test?

Thanks for the review, done.

@rhatdan
Copy link
Member

rhatdan commented Sep 22, 2022

LGTM
@mheon PTAL
@containers/podman-maintainers PTAL

@mheon
Copy link
Member

mheon commented Sep 22, 2022

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: idleroamer, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2022
@openshift-merge-robot openshift-merge-robot merged commit 828fae1 into containers:main Sep 22, 2022
@idleroamer idleroamer deleted the podman-save branch September 22, 2022 13:24
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

podman save cli doesn't support --signature-policy
4 participants