cmd/podman: add support for checkpoint images #15868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note
do-not-merge/work-in-progress
rst0git
force-pushed
the
podman-run-checkpoint-img
branch
from
ae1c46a to
cb0ea68
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
rst0git
force-pushed
the
podman-run-checkpoint-img
branch
3 times, most recently
from
7957a1a to
8ecfe7b
Compare
|
@adrianreber PTAL |
rhatdan
reviewed
Sep 23, 2022
rhatdan
reviewed
Sep 23, 2022
rhatdan
reviewed
Sep 23, 2022
rhatdan
reviewed
Sep 23, 2022
rst0git
force-pushed
the
podman-run-checkpoint-img
branch
3 times, most recently
from
b0834e6 to
d2e08c8
Compare
From my point of view this makes sense. If the checkpoint is part of an OCI image it feels a lot more natural to use |
rst0git
force-pushed
the
podman-run-checkpoint-img
branch
from
d2e08c8 to
da32553
Compare
vrothberg
reviewed
Sep 29, 2022
Podman allows to store a container checkpoints as an images. This patch makes the check that is used to recognise such checkpoint images reusable by moving it in utils. This functionality will be reused in a subsequent patch to extend the `podman run` command with support for checkpoint images. Signed-off-by: Radostin Stoyanov <[email protected]>
This patch extends the podman run command with support for checkpoint
images. When `podman run` is invoked with an image that contains
a checkpoint, it would restore the container from that checkpoint.
Example:
podman run -d --name looper busybox /bin/sh -c \
'i=0; while true; do echo $i; i=$(expr $i + 1); sleep 1; done'
podman container checkpoint --create-image checkpoint-image-1 looper
podman run checkpoint-image-1
Signed-off-by: Radostin Stoyanov <[email protected]>
The `podman run` command has been extended with support for checkpoint images. A checkpoint image contains image files generated by criu that allow to restore the runtime state of containerized applications. This patch adds a test case for this functionality. Signed-off-by: Radostin Stoyanov <[email protected]>
rst0git
force-pushed
the
podman-run-checkpoint-img
branch
from
da32553 to
ebff193
Compare
vrothberg
reviewed
Sep 29, 2022
|
/approve |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan, rst0git The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request extends the podman run command with support for checkpoint images. When
podman runis invoked with an image that contains a checkpoint, it would restore the container from that checkpoint.Example:
Does this PR introduce a user-facing change?