Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] man pages: document some --format options #15859

Merged

Conversation

edsantiago
Copy link
Member

Baby steps toward merging #14046: document Go format options
for podman events.

This is deliberately imperfect. I am not the right person
to document these. I am simply the person who is getting
a skeleton framework in place.

Signed-off-by: Ed Santiago [email protected]

man pages: document Go format values for podman-events

Baby steps toward merging containers#14046: document Go format options
for podman events.

This is deliberately imperfect. I am not the right person
to document these. I am simply the person who is getting
a skeleton framework in place.

Signed-off-by: Ed Santiago <[email protected]>
@edsantiago edsantiago added the kind/documentation Categorizes issue or PR as related to documentation. label Sep 19, 2022
@openshift-ci openshift-ci bot added release-note approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 19, 2022
@rhatdan
Copy link
Member

rhatdan commented Sep 19, 2022

LGTM

@mheon
Copy link
Member

mheon commented Sep 19, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mheon
Copy link
Member

mheon commented Sep 19, 2022

I kind of hate having to include things like "Details" in the output. I understand it's necessary for completion/testing, but it's not something anyone should ever use...

@openshift-merge-robot openshift-merge-robot merged commit 30231d0 into containers:main Sep 19, 2022
@edsantiago edsantiago deleted the docs_format_events branch September 19, 2022 18:33
@edsantiago
Copy link
Member Author

@mheon I hate it too... so I've made an experimental tweak to my xref script so it'll silently recognize this:

diff --git a/docs/source/markdown/podman-events.1.md b/docs/source/markdown/podman-events.1.md
index dd62ef5a2..df08b7d14 100644
--- a/docs/source/markdown/podman-events.1.md
+++ b/docs/source/markdown/podman-events.1.md
@@ -99,7 +99,6 @@ Format the output to JSON Lines or using the given Go template.                                                                              
 |--------------------|-----------------------------------------------|
 | .Attributes        | created_at, _by, labels, and more (map[])     |
 | .ContainerExitCode | Exit code (int)                               |
-| .Details ...       | Internal structure, not actually useful       |
 | .HealthStatus      | Health Status (string)                        |
 | .ID                | Container ID (full 64-bit SHA)                |
 | .Image             | Name of image being run (string)              |
@@ -109,6 +108,8 @@ Format the output to JSON Lines or using the given Go template.                                                                            
 | .Time              | Event timestamp (string)                      |
 | .Type              | Event type (e.g., image, container, pod, ...) |
 
+[//]: # (.Details - INTERNAL)
+
 #### **--help**
 
 Print usage statement.

Based on this hint about comments in markdown. The man page is unaffected, there is no extra whitespace or noise that I can see. Likewise the html. User-friendlier, at the cost of dev-unfriendliness. WDYT?

@edsantiago
Copy link
Member Author

Can't prevent it from showing up in autocomplete, though - so maybe it's better to document it as "please ignore" than to have people search in vain.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants