Improve generate systemd format #15837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/release-note-label-needed
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
approved
rhatdan
force-pushed
the
format
branch
2 times, most recently
from
efdbe56 to
d750619
Compare
vrothberg
reviewed
Sep 20, 2022
| @@ -177,8 +177,11 @@ ExecStart=/usr/local/bin/podman run | |||
| --cgroups=no-conmon | |||
| -d | |||
| -dit alpine | |||
| ExecStop=/usr/local/bin/podman stop --ignore --cidfile %t/%n-cid -t 10 | |||
| ExecStopPost=/usr/local/bin/podman rm --ignore -f --cidfile %t/%n-cid | |||
| ExecStop=/usr/local/bin/podman stop --ignore | |||
There was a problem hiding this comment.
Shouldn't the lines be escaped?
Fixes: containers#14897 Followup to containers#13814 Signed-off-by: Daniel J Walsh <[email protected]>
vrothberg
reviewed
Sep 21, 2022
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #14897
Followup to #13814
Signed-off-by: Daniel J Walsh [email protected]
Does this PR introduce a user-facing change?