[CI:BUILD] Contrib: Add containerfile to create podman-remote binary image #15813

praveenkumar · 2022-09-15T05:58:14Z

Try to partial address #14664

- Add container file to build remote binary for each platform
- Add README.md file around same

Longer term plan is to have it attach either to quay and add github trigger to generate the image for each 4.x tag/branch. Only issue is as of now quay github trigger can only generate amd64 images not the arm64 one so may be we need to attach it to current cirrus CI to generate image for different arch and push to quay, same way we are doing for quay.io/containers/podman.

Another gap is created binaries for mac/windows are not signed one and we need to check if user try to copy those binary from the container image does it showing the signing warning.

flouthoc

LGTM other than two nits above.

flouthoc · 2022-09-15T09:23:29Z

contrib/podmanremoteimage/README.md

+
+- For Linux binary
+```bash
+$ podman cp $(podman create --name remote-temp quay.io/praveenkumar/podman-remote-artifacts:latest):/podman-remote-static . && podman rm remote-temp


Suggested change

$ podman cp $(podman create --name remote-temp quay.io/praveenkumar/podman-remote-artifacts:latest):/podman-remote-static . && podman rm remote-temp

$ podman cp $(podman create --name remote-temp quay.io/containers/podman-remote-artifacts:latest):/podman-remote-static . && podman rm remote-temp

Points to personal repo, are we expecting to create similar repo/tag in containers

I think similar comment goes for darwin

@flouthoc yes I forgot to remove my personal repo :) . I think we should have similar repo/tag in containers org for consumption.

openshift-ci · 2022-09-15T09:24:33Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, praveenkumar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [flouthoc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rhatdan · 2022-09-15T10:43:06Z

@mheon @cevich @vrothberg PTAL

vrothberg · 2022-09-15T10:58:10Z

contrib/podmanremoteimage/README.md

+
+This directory contains the containerfile for creating a container image which consist podman-remote binary
+for each platform (win/linux/mac). Plan is to hook it with quay github build trigger to generate this image
+for each PR merged (in any 4.x branch or tags).


Suggested change

for each PR merged (in any 4.x branch or tags).

for each PR merged (for any branch or tag).

vrothberg

What is the benefit over curl-ing the binaries from the release pages? I assume for testing purposes but I'd appreciate making the intention explicit in the README.

I'd like some more maintainers to have a look.

vrothberg · 2022-09-15T10:58:35Z

contrib/podmanremoteimage/README.md

+for each platform (win/linux/mac). Plan is to hook it with quay github build trigger to generate this image
+for each PR merged (in any 4.x branch or tags).
+
+User can copy those binary on specific platform using following


Suggested change

User can copy those binary on specific platform using following

Users can copy the binaries onto the specific platforms using following instructions

cevich · 2022-09-15T13:41:30Z

Longer term plan is to have it attach either to quay and add github trigger to generate the image for each 4.x tag/branch.

Yeah, can't use quay. We have two Cirrus-CI tasks setup to build multi-arch image manifests, image_build and test_image_build. The later is intended for PRs (like this one) so you can test out new/changed builds. It's only available for manual-trigger, and only if you put [CI:BUILD] in the PR description (which I just did).

cevich · 2022-09-15T13:43:22Z

So on your next force-push, you'll see the test_image_build manual-trigger jobs pop up. I'll most likely need to help add the new one, since the build script is sensitive to the directory names.. I'll also need to setup the new repo in quay for it to push to.

cevich · 2022-09-15T13:51:58Z

Q: @rhatdan @TomSweeneyRedHat or anyone else: do we want to provide the stable, testing, and upstream flavors of the podman-remote image as well as a secondary push to quay.io/containers/podman:{stable, testing, upstream} and quay.io/podman-remote (new repo)? Since that logic is already cooked into the build script, it would be good to iron this all out up-front if possible.

cevich · 2022-09-15T14:00:17Z

contrib/podmanremoteimage/Containerfile

@@ -0,0 +1,10 @@
+FROM registry.access.redhat.com/ubi8/go-toolset:latest AS builder


All of our other container images are based on registry.fedoraproject.org/fedora:latest, for consistency it would be good to use that here too. An alternative could be registry.fedoraproject.org/fedora-minimal:latest. In either case, check out the contrib/podmanimage/*/Containerfiles to see how we install podman. It's MUCH faster to install than to compile during image-build time (due to needing emulation).

errr...nevermind 😞 that won't work for Mac or Windows will it? My concern is the multi-arch compiles are extremely slow under emulation. Hmmmm. Perhaps the thing to do is just grab the binaries directly from the CI system's artifacts task. They're not signed, but will be posted continuously for main, and recent release-branches (where we added ARM64 builds).

@cevich Does it also published for specific tags like rc one? One of the use case which I am trying to solve with it, if we do any release on github (with specific branch) be it alpha, beta, rc we should have release binaries for those bits (longer term) either through the container image or from the CI artifacts. If I see #15202 (which is the PR for rc3) then looks like we just use the rc3 commit to do the tagging and there is no CI artifact for it.

Mostly, I don't think tags to, but for sure on most recent branches (and going forward) the CI system continuously publishes artifacts at a consistent URL. The URL will be of the form specified here: https://cirrus-ci.org/guide/writing-tasks/#latest-build-artifacts

contrib/podmanremoteimage/README.md

cevich · 2022-09-19T19:42:37Z

contrib/podmanremoteimage/Containerfile

+COPY . .
+RUN make podman-remote-static
+RUN GOOS=windows make podman-remote
+RUN GOOS=darwin make podman-remote


What do you think of: Instead of compiling, curl the latest binaries from CI system using the branch-name specified as a build-arg?

I like that idea, then we know everyone is using the exact same binary.

@cevich if we are adding this to CI for each PR then first we have to wait for other CI run to be succeed (to generate required images) as part of some step builds?

Not the way the builds run today. They're optional on [CI:BUILD] PRs (to support testing/development). Otherwise they only run via a daily cron-job on main.

Try to partial address containers#14664 Signed-off-by: Praveen Kumar <[email protected]>

rhatdan · 2022-09-26T14:30:01Z

/lgtm

TomSweeneyRedHat · 2022-10-04T21:58:04Z

contrib/podmanremoteimage/README.md

+Overview
+--------
+
+This directory contains the containerfile for creating a container image which consist podman-remote binary


Nit and way past, but just in case containerfile -> Containerfile

TomSweeneyRedHat · 2022-10-04T21:59:12Z

contrib/podmanremoteimage/README.md

+This directory contains the containerfile for creating a container image which consist podman-remote binary
+for each platform (win/linux/mac).
+
+Users can copy those binaries onto the specific platforms using following instructions


following -> the following

openshift-ci bot added the release-note label Sep 15, 2022

praveenkumar force-pushed the podman-remote-container-file branch from 657931f to 23a9733 Compare September 15, 2022 08:45

flouthoc approved these changes Sep 15, 2022

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2022

vrothberg reviewed Sep 15, 2022

View reviewed changes

praveenkumar force-pushed the podman-remote-container-file branch from 23a9733 to 6c162a3 Compare September 15, 2022 11:00

vrothberg reviewed Sep 15, 2022

View reviewed changes

cevich changed the title ~~Contrib: Add containerfile to create podman-remote binary image~~ [CI:BUILD] Contrib: Add containerfile to create podman-remote binary image Sep 15, 2022

cevich reviewed Sep 15, 2022

View reviewed changes

contrib/podmanremoteimage/README.md Outdated Show resolved Hide resolved

cevich reviewed Sep 15, 2022

View reviewed changes

contrib/podmanremoteimage/README.md Show resolved Hide resolved

cevich reviewed Sep 19, 2022

View reviewed changes

Contrib: Add containerfile to create podman-remote binary image

8c627df

Try to partial address containers#14664 Signed-off-by: Praveen Kumar <[email protected]>

praveenkumar force-pushed the podman-remote-container-file branch from 6c162a3 to 8c627df Compare September 26, 2022 05:04

openshift-ci bot assigned rhatdan Sep 26, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2022

openshift-merge-robot merged commit cf6136f into containers:main Sep 26, 2022

TomSweeneyRedHat reviewed Oct 4, 2022

View reviewed changes

github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023

github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CI:BUILD] Contrib: Add containerfile to create podman-remote binary image #15813

[CI:BUILD] Contrib: Add containerfile to create podman-remote binary image #15813

praveenkumar commented Sep 15, 2022

flouthoc left a comment

flouthoc Sep 15, 2022

flouthoc Sep 15, 2022 •

edited

Loading

flouthoc Sep 15, 2022

praveenkumar Sep 15, 2022

openshift-ci bot commented Sep 15, 2022

rhatdan commented Sep 15, 2022

vrothberg Sep 15, 2022

vrothberg left a comment

vrothberg Sep 15, 2022

cevich commented Sep 15, 2022

cevich commented Sep 15, 2022

cevich commented Sep 15, 2022

cevich Sep 15, 2022

cevich Sep 15, 2022

praveenkumar Sep 19, 2022

cevich Sep 19, 2022

cevich Sep 19, 2022

rhatdan Sep 19, 2022

praveenkumar Sep 26, 2022

cevich Sep 26, 2022

rhatdan commented Sep 26, 2022

TomSweeneyRedHat Oct 4, 2022

TomSweeneyRedHat Oct 4, 2022

	$ podman cp $(podman create --name remote-temp quay.io/praveenkumar/podman-remote-artifacts:latest):/podman-remote-static . && podman rm remote-temp
	$ podman cp $(podman create --name remote-temp quay.io/containers/podman-remote-artifacts:latest):/podman-remote-static . && podman rm remote-temp

	for each PR merged (in any 4.x branch or tags).
	for each PR merged (for any branch or tag).

	User can copy those binary on specific platform using following
	Users can copy the binaries onto the specific platforms using following instructions

		@@ -0,0 +1,10 @@
		FROM registry.access.redhat.com/ubi8/go-toolset:latest AS builder

[CI:BUILD] Contrib: Add containerfile to create podman-remote binary image #15813

[CI:BUILD] Contrib: Add containerfile to create podman-remote binary image #15813

Conversation

praveenkumar commented Sep 15, 2022

flouthoc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flouthoc Sep 15, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

openshift-ci bot commented Sep 15, 2022

rhatdan commented Sep 15, 2022

Choose a reason for hiding this comment

vrothberg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cevich commented Sep 15, 2022

cevich commented Sep 15, 2022

cevich commented Sep 15, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rhatdan commented Sep 26, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flouthoc Sep 15, 2022 •

edited

Loading