Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats: cap memory limit to the available memory #15811

Merged
merged 2 commits into from
Sep 15, 2022

Conversation

giuseppe
Copy link
Member

Docker compatibility: cap the memory limit reported by the cgroup to the maximum available memory.

Closes: #15765

Signed-off-by: Giuseppe Scrivano [email protected]

Does this PR introduce a user-facing change?

compact API: Cap the memory limit to the total available memory

and make sure it is not set for cgroup v2

Signed-off-by: Giuseppe Scrivano <[email protected]>
@github-actions github-actions bot added the kind/api-change Change to remote API; merits scrutiny label Sep 14, 2022
@openshift-ci openshift-ci bot added release-note approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 14, 2022
Copy link
Member

@edsantiago edsantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work - this has been long overdue. One recommendation inline. Thank you!

test/apiv2/test-apiv2 Outdated Show resolved Hide resolved
Docker compatibility: cap the memory limit reported by the cgroup to
the maximum available memory.

Closes: containers#15765

Signed-off-by: Giuseppe Scrivano <[email protected]>
@giuseppe giuseppe force-pushed the fix-memory-stats-api branch from aac1913 to 60ef4ad Compare September 15, 2022 07:00
@rhatdan
Copy link
Member

rhatdan commented Sep 15, 2022

LGTM
@containers/podman-maintainers PTAL

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrothberg
Copy link
Member

Thanks, @giuseppe !

@openshift-merge-robot openshift-merge-robot merged commit 2a8df49 into containers:main Sep 15, 2022
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Change to remote API; merits scrutiny lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

memory Limit is returning invalid result for /container/stats REST API on macOS
5 participants