-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stats: cap memory limit to the available memory #15811
stats: cap memory limit to the available memory #15811
Conversation
and make sure it is not set for cgroup v2 Signed-off-by: Giuseppe Scrivano <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work - this has been long overdue. One recommendation inline. Thank you!
Docker compatibility: cap the memory limit reported by the cgroup to the maximum available memory. Closes: containers#15765 Signed-off-by: Giuseppe Scrivano <[email protected]>
aac1913
to
60ef4ad
Compare
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks, @giuseppe ! |
Docker compatibility: cap the memory limit reported by the cgroup to the maximum available memory.
Closes: #15765
Signed-off-by: Giuseppe Scrivano [email protected]
Does this PR introduce a user-facing change?