Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ci: update systemd generate unit test #15796

Merged
merged 1 commit into from
Sep 14, 2022
Merged

fix ci: update systemd generate unit test #15796

merged 1 commit into from
Sep 14, 2022

Conversation

vrothberg
Copy link
Member

Two PRs have been merged causing a failure in one unit test. Fix the unit test to turn CI green again.

Signed-off-by: Valentin Rothberg [email protected]

Does this PR introduce a user-facing change?

None

@containers/podman-maintainers URGENT, PTAL

Just found the issue locally. I hope we can merge it quickly before it's hitting new PRs.

@vrothberg
fix ci: update systemd generate unit test
dd53ee5 
Two PRs have been merged causing a failure in one unit test.
Fix the unit test to turn CI green again.

Signed-off-by: Valentin Rothberg <[email protected]>
@openshift-ci openshift-ci bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 14, 2022
Luap99
Luap99 approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Sep 14, 2022
@edsantiago edsantiago mentioned this pull request Sep 14, 2022
Closed
giuseppe
giuseppe approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, Luap99, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Luap99,giuseppe,vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@giuseppe
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2022
@edsantiago
Copy link
Member

/hold

CI is still in progress (and, sigh, flaking)

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2022
@giuseppe
Copy link
Member

true, but this PR is touching only a _test.go file and it is passing now. Other failures are not related to this PR

@mheon
Copy link
Member

mheon commented Sep 14, 2022

Can't merge until Total Success is green, though - branch protection should prevent it (at least for bots)

@edsantiago
Copy link
Member

@giuseppe my understanding is that CI has to be fully green before a hold can be released. Bug in the merge thingy. #10295 (comment)

Anyhow, I've been trained to never, ever, ever set the merge labels until CI is green. Maybe the bug has been fixed, if so, someone please inform me.

@edsantiago
Copy link
Member

Now it's green.
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2022
@openshift-merge-robot openshift-merge-robot merged commit a3876c2 into containers:main Sep 14, 2022
@vrothberg vrothberg deleted the fix-ci branch September 14, 2022 14:31
@edsantiago edsantiago mentioned this pull request Sep 19, 2022
Closed
@edsantiago edsantiago mentioned this pull request Oct 6, 2022
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Luap99 Luap99 Luap99 approved these changes

@giuseppe giuseppe giuseppe approved these changes

Assignees

@Luap99 Luap99

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vrothberg @giuseppe @edsantiago @mheon @Luap99 @openshift-merge-robot