all: stop using deprecated GenerateNonCryptoID #15788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In view of containers/storage#1337, do this: for f in $(git grep -l stringid.GenerateNonCryptoID | grep -v '^vendor/'); do sed -i 's/stringid.GenerateNonCryptoID/stringid.GenerateRandomID/g' $f; done Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
force-pushed
the
non-crypto-id
branch
from
0eeb467 to
75740be
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kolyshkin, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
rhatdan
added a commit
that referenced
this pull request
Jan 27, 2023
Backport #15788 to v3.0.1-rhel
TomSweeneyRedHat
pushed a commit
to TomSweeneyRedHat/podman
that referenced
this pull request
Feb 1, 2023
Cherry-pick containers#15788 to v4.2.0-rhel branch per RHBZ 2157930 In view of containers/storage#1337, do this: for f in $(git grep -l stringid.GenerateNonCryptoID | grep -v '^vendor/'); do sed -i 's/stringid.GenerateNonCryptoID/stringid.GenerateRandomID/g' $f; done Signed-off-by: Kir Kolyshkin <[email protected]> Signed-off-by: tomsweeneyredhat <[email protected]>
TomSweeneyRedHat
pushed a commit
to TomSweeneyRedHat/podman
that referenced
this pull request
Feb 1, 2023
Cherry-pick containers#15788 to v4.1.1-rhel branch per RHBZ 2157930 In view of containers/storage#1337, do this: for f in $(git grep -l stringid.GenerateNonCryptoID | grep -v '^vendor/'); do sed -i 's/stringid.GenerateNonCryptoID/stringid.GenerateRandomID/g' $f; done Signed-off-by: Kir Kolyshkin <[email protected]> Signed-off-by: tomsweeneyredhat <[email protected]>
TomSweeneyRedHat
pushed a commit
to TomSweeneyRedHat/podman
that referenced
this pull request
Feb 1, 2023
Cherry-pick containers#15788 to v4.0-rhel branch per RHBZ 2157930 In view of containers/storage#1337, do this: for f in $(git grep -l stringid.GenerateNonCryptoID | grep -v '^vendor/'); do sed -i 's/stringid.GenerateNonCryptoID/stringid.GenerateRandomID/g' $f; done Signed-off-by: Kir Kolyshkin <[email protected]> Signed-off-by: tomsweeneyredhat <[email protected]>
TomSweeneyRedHat
pushed a commit
to TomSweeneyRedHat/podman
that referenced
this pull request
Feb 4, 2023
Cherry-pick containers#15788 to v3.4.2-rhel branch per RHBZ 2157930 In view of containers/storage#1337, do this: for f in $(git grep -l stringid.GenerateNonCryptoID | grep -v '^vendor/'); do sed -i 's/stringid.GenerateNonCryptoID/stringid.GenerateRandomID/g' $f; done Also added these commits to test/e2e/search_test.go in hopes fixing test errors for the original commit: containers@7a9c14d containers@ae9a2d2 Signed-off-by: Kir Kolyshkin <[email protected]> Signed-off-by: tomsweeneyredhat <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In view of containers/storage#1337, do this:
(Note that this PR does not depend on one in containers/storage).
Does this PR introduce a user-facing change?