Use new secret store API #15723
Closed
Use new secret store API #15723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashley-cui
added
the
do-not-merge/work-in-progress
openshift-ci
bot
added
release-note-none
and removed
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashley-cui The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-ci
bot
added
the
do-not-merge/work-in-progress
ashley-cui
force-pushed
the
secretapi
branch
3 times, most recently
from
5713ac8 to
c97f155
Compare
Refactored secrets API in common for stability purposes. Move podman to said API. [NO NEW TESTS NEEDED] Signed-off-by: Ashley Cui <[email protected]>
ashley-cui
force-pushed
the
secretapi
branch
from
c97f155 to
89c893e
Compare
ashley-cui
removed
the
do-not-merge/work-in-progress
|
Ready to look at! This should unblock vendoring, as it vendors common@main and deals with the breaking change in the secrets API. |
|
Event tests aren't happy. @Luap99 probably you need to cherry-pick this commit here or the other way around. |
|
I cherry-picked it into #15717. |
|
Thanks! Let's close this PR there then. |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored secrets API in common for stability purposes. Move podman to
said API.
Does this PR introduce a user-facing change?