Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system tests: periodic cleanup and fixes #15678

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

edsantiago
Copy link
Member

  • basic : confirm that --debug/-D emit debug messages
  • events : clean up, add --format tests
  • systemd : reorder proxy args for legibility
  • auto-update : fix missing timeout that could lead to hang

Signed-off-by: Ed Santiago [email protected]

None

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2022
@rhatdan
Copy link
Member

rhatdan commented Sep 7, 2022

LGTM

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Member

rhatdan commented Sep 8, 2022

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 8, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2022
@mheon
Copy link
Member

mheon commented Sep 8, 2022

Local root system tests are failing

@edsantiago
Copy link
Member Author

#15488, the metacopy one. It's getting pretty bad.

@edsantiago
Copy link
Member Author

Well, looks like this is on hold until someone fixes #15698

@rhatdan
Copy link
Member

rhatdan commented Sep 12, 2022

Since #15698 is closed, can this move forward after a rebase.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2022
@edsantiago edsantiago marked this pull request as draft September 12, 2022 14:00
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 12, 2022
@edsantiago
Copy link
Member Author

Re-pushed, but please do not merge yet, it will conflict with #15717.

Luap99 added a commit to Luap99/libpod that referenced this pull request Sep 12, 2022
The --format changes caused a duplicated newline.
PR containers#15678 should have a test for this.

Signed-off-by: Paul Holzinger <[email protected]>
- basic       : add actual log-level tests
- events      : clean up, add --format tests
- systemd     : reorder proxy args for legibility
- auto-update : fix missing timeout that could lead to hang

Signed-off-by: Ed Santiago <[email protected]>
@edsantiago edsantiago marked this pull request as ready for review September 12, 2022 18:20
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 12, 2022
@TomSweeneyRedHat
Copy link
Member

Changes LGTM

@rhatdan
Copy link
Member

rhatdan commented Sep 12, 2022

/lgtm

@rhatdan
Copy link
Member

rhatdan commented Sep 12, 2022

/hold cancel

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2022
@openshift-merge-robot openshift-merge-robot merged commit 4aeaeaf into containers:main Sep 12, 2022
@edsantiago edsantiago deleted the bats_cleanup branch September 13, 2022 13:15
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants