fix podman pod inspect to support multiple pods

[Luap99]

Just like the other inspect commands podman pod inspect p1 p2 should return the json for both.

To correctly implement this we follow the container inspect logic, this
allows use to reuse the global inspect command.
Note: To not break the existing single pod output format for podman pod
inspect I added a pod-legacy inspect type. This is only used to make
sure we will print the pod as single json and not an array like for the
other commands. We cannot use the pod type since podman inspect --type
pod did return an array and we should not break that as well.

Fixes #15674

Signed-off-by: Paul Holzinger [email protected]

Does this PR introduce a user-facing change?

podman pod inspect will now correctly work for more than one pod.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Luap99]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mheon]

Can we return a single pod, and not an array, when only a single pod is returned? Would prevent a break in backwards-compat.

[Luap99]

Can we return a single pod, and not an array, when only a single pod is returned? Would prevent a break in backwards-compat.

I think this would be good solution.

[Luap99]

OK, I think this should work now without breaking changes.

[rhatdan]

LGTM
Should we open an issue to fix this for 5.0?

[Luap99]

We can create an issue, I always add a TODO (5.0) comment so I do not forget them.

 $ vgrep 'TODO (5.0)'
Index File                           Line Content
    0 libpod/networking_linux.go:931  931 // TODO (5.0): return the statistics per network interface
    1 pkg/specgen/specgen.go:487      487 // TODO (5.0): change to pointer

[Luap99]

@mheon @vrothberg PTAL

[vrothberg]

LGTM

[vrothberg]

/lgtm