Add --config for Docker compatibility #15658
Conversation
openshift-ci
bot
added
release-note
approved
|
Also helps fix: #14917 |
cmd/podman/root.go
Outdated
| @@ -363,6 +363,8 @@ func rootFlags(cmd *cobra.Command, opts *entities.PodmanConfig) { | |||
| lFlags.StringVarP(&opts.URI, "host", "H", uri, "Used for Docker compatibility") | |||
| _ = lFlags.MarkHidden("host") | |||
|
|
|||
| lFlags.String("config", "", "Ignored for Docker compatibility") | |||
There was a problem hiding this comment.
I don't like the user experience when silently ignoring the option. I would expect it to have some impact. An error as at the moment at least tells me that it's not going to work.
I would prefer to keep erroring out or do an logrus.Errorf("--config is not supported") that screams at the user.
There was a problem hiding this comment.
I can add the logrus.Error, but the problem was tools that were doing
docker --config ...
When users commented out this option, everything worked properly.
If we start spewing errors then it could be an aggravation.
There was a problem hiding this comment.
I understand the intention. It's a delicate art. I am mostly afraid to let users believe into thinking that --config $lifeOrDeath would work.
There was a problem hiding this comment.
Lets settle on a warning.
Fixes: containers#14767 Signed-off-by: Daniel J Walsh <[email protected]>
|
@containers/podman-maintainers PTAL |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-actions
bot
added
the
locked - please file new issue/PR
Fixes: #14767
Signed-off-by: Daniel J Walsh [email protected]
Does this PR introduce a user-facing change?