Upgrade go-criu to v6

[snprajwal]

The v6.0.0 release of go-criu has deprecated the rpc and stats
packages in favour of the crit package. This commit provides the
changes required to use this version in podman.

Signed-off-by: Prajwal S N [email protected]

None

[mheon]

Looks like you have build issues, but changes LGTM otherwise

[snprajwal]

Looks like you have build issues

There's a namespace conflict between the proto files from another dependency. I'll get this repaired and working shortly.

[TomSweeneyRedHat]

LGTM
assuming happy tests

[snprajwal]

@mheon @TomSweeneyRedHat would it be possible to override the CI constraint for binary deltas over 51200B? The remaining tests are passing :)

[rst0git]

LGTM

[mheon]

@baude @Luap99 Looks like ~1mb of growth. I'm OK with merging, but you both have stronger opinions on this than I do.

[Luap99]

Eh, why exactly do we need this? +1 MB for no new features?
It looks like the dependency structure for go-criu/v6 is bad. It pulls in way to much because of the stupid protobuf code generation, one of the reason we dropped the k8s dep.

[rhatdan]

Can we work around this issue. One of the things Automotive wants out of us is guarantees that we prevent the start up time of Podman from going up. Each time it gets fatter, the total time of starting the podman command slows down. Automotive has a requirement to start container from boot in < 2 seconds.

[rst0git]

why exactly do we need this? +1 MB for no new features?

In go-criu version 6.X we introduced support for image processing functionality (crit) and we plan to extend the podman inspect command with support for checkpoint container images. This functionality also replaces the existing stats API and would also allow us to enable pre-copy container migration.

[rhatdan]

Can you do something about the protobuf problem @Luap99 mentions?

[snprajwal]

Can you do something about the protobuf problem @Luap99 mentions?

Although we do not need all the bindings for the stats API, they will be required to extend podman inspect for checkpointed images.

[rst0git]

Can you do something about the protobuf problem @Luap99 mentions?

We briefly discussed this problem in checkpoint-restore/go-criu#95 (comment), but so far this is the best solution we have.

[adrianreber]

I agree over 1MB increase of binary size for just moving code around does not sound right. It is not clear why the binary size increases so much as non of the imported protobuf files are actually used. We need to structure go-criu differently.

[snprajwal]

It is not clear why the binary size increases so much as non of the imported protobuf files are actually used.

Since all Go programs are statically linked, the Go compiler includes the entire library, even if just a single function is being used (in this case, crit/images). On the other hand, if we add a bunch of new features that use the same libraries, the size increase will be in the order of a few bytes, since nothing needs to be included from the imports.

[github-actions]

A friendly reminder that this PR had no activity for 30 days.

[rst0git]

@snprajwal Would you be able to update this pull request with go-criu version 6.3.0 (e.g., a71a19e)?
This version should be backwards compatible with v5 and therefore the size of the podman binary shouldn't change.

[rst0git]

@Luap99 @mheon @rhatdan PTAL

[Luap99]

LGTM, thanks for fixing this

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, rst0git, snprajwal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Luap99]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

/lgtm