Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:BUILD] Packit: Disable until proved in other repos #15572

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Aug 31, 2022

There are concerns with Packit causing flakes and delays on Podman so
let's have Packit prove itself in other repos and only then make its way
into Podman.

See: #15549 (comment)

[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar [email protected]

Does this PR introduce a user-facing change?

None

@edsantiago PTAL

@packit-as-a-service
Copy link

Failed to load packit config file:

Cannot parse package config: AttributeError("'NoneType' object has no attribute 'get'").

For more info, please check out the documentation or contact the Packit team.

@openshift-ci openshift-ci bot added release-note-none do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 31, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2022
@packit-as-a-service
Copy link

Failed to load packit config file:

Cannot parse package config: AttributeError("'NoneType' object has no attribute 'get'").

For more info, please check out the documentation or contact the Packit team.

@lsm5
Copy link
Member Author

lsm5 commented Aug 31, 2022

hmm, guess it's best I just delete the packit files to stop packit bot complaints.

@packit-as-a-service
Copy link

Failed to load packit config file:

Cannot parse package config: AttributeError("'NoneType' object has no attribute 'get'").

For more info, please check out the documentation or contact the Packit team.

There are concerns with Packit causing flakes and delays on Podman so
let's have Packit prove itself in other repos and only then make its way
into Podman.

See: containers#15549 (comment)

[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5 lsm5 marked this pull request as ready for review August 31, 2022 19:20
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 31, 2022
@edsantiago
Copy link
Member

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 31, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2022
@lsm5
Copy link
Member Author

lsm5 commented Aug 31, 2022

@edsantiago good to go

@edsantiago
Copy link
Member

@lsm5 it's a hold -- you have the power. ("You've always had the power"). On a hold, you can just type slash-hold-space-cancel

@lsm5
Copy link
Member Author

lsm5 commented Sep 1, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2022
@lsm5
Copy link
Member Author

lsm5 commented Sep 1, 2022

@lsm5 it's a hold -- you have the power. ("You've always had the power"). On a hold, you can just type slash-hold-space-cancel

sure, though I kinda prefer whoever put the hold to also remove it just in case they had any other concerns. Thanks :)

@openshift-merge-robot openshift-merge-robot merged commit 54873c1 into containers:main Sep 1, 2022
@lsm5 lsm5 deleted the disable-packit branch March 16, 2023 11:25
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants