Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v4.2] Handle an already connected network in libpod API #15554

Merged
merged 1 commit into from
Aug 31, 2022
Merged

[v4.2] Handle an already connected network in libpod API #15554

merged 1 commit into from
Aug 31, 2022

Conversation

openshift-cherrypick-robot
Copy link
Collaborator

This is an automated cherry-pick of #15516

/assign n1hility

ErrNetworkConnected was introduced for when trying to connect a container to a network it is already connected to

@kubealex @baude @n1hility
Fix containers#15499 already connected network
3439657 
Compat: Treat already attached networks as a no-op
Applies only to containers in created state. Maintain error in running state.

Co-authored-by: Alessandro Rossi <[email protected]>
Co-authored-by: Brent Baude <[email protected]>
Co-authored-by: Jason T. Greene <[email protected]>
Signed-off-by: Alessandro Rossi <[email protected]>
Signed-off-by: Jason T. Greene <[email protected]>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 30, 2022
Merged
@rhatdan
Copy link
Member

rhatdan commented Aug 31, 2022

/approve
/lgtm

@rhatdan
Copy link
Member

rhatdan commented Aug 31, 2022

/hold

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Aug 31, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2022
@rhatdan
Copy link
Member

rhatdan commented Aug 31, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 31, 2022
@openshift-merge-robot openshift-merge-robot merged commit badbe62 into containers:v4.2 Aug 31, 2022
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@n1hility n1hility

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@openshift-cherrypick-robot @rhatdan @n1hility @openshift-merge-robot @kubealex