Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to reserve buildah labels as well as podman labels #1555

Closed
wants to merge 1 commit into from
Closed

Need to reserve buildah labels as well as podman labels #1555

wants to merge 1 commit into from

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Sep 27, 2018

Signed-off-by: Daniel J Walsh [email protected]

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 27, 2018
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rhatdan

If they are not already assigned, you can assign the PR to them by writing /assign @rhatdan in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

TomSweeneyRedHat
TomSweeneyRedHat reviewed Sep 27, 2018
View reviewed changes
libpod/runtime_ctr.go
containers, err := r.state.AllContainers()
if err != nil {
return err
return errors.Wrapf(err, "error getting containers to reserving labels")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit of a nit serving to reserve

@TomSweeneyRedHat
Copy link
Member

Changes LGTM, but tests aren't hip

@rh-atomic-bot
Copy link
Collaborator

☔ The latest upstream changes (presumably #1600) made this pull request unmergeable. Please resolve the merge conflicts.

@rhatdan rhatdan changed the title [WIP] Need to reserve buildah labels as well as podman labels Need to reserve buildah labels as well as podman labels Oct 8, 2018
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2018
@rhatdan
Copy link
Member Author

rhatdan commented Oct 9, 2018

bot, retest this please

@rh-atomic-bot
Copy link
Collaborator

☔ The latest upstream changes (presumably #1662) made this pull request unmergeable. Please resolve the merge conflicts.

@mheon
Copy link
Member

mheon commented Oct 23, 2018

Should not be necessary, we do this in c/storage now

@mheon mheon closed this Oct 23, 2018
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TomSweeneyRedHat TomSweeneyRedHat TomSweeneyRedHat left review comments

@baude baude Awaiting requested review from baude

@vrothberg vrothberg Awaiting requested review from vrothberg

Assignees
No one assigned
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rhatdan @openshift-ci-robot @TomSweeneyRedHat @rh-atomic-bot @mheon