-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily Revert "Packit: Enable scratch build testing for Fedora 36, 37 and Rawhide" #15480
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…6, 37 and Rawhide" Packit will probably be brought back soon after including fix-spec-file-action. See: PR containers#15457 This reverts commit d45a5d4. [NO NEW TESTS NEEDED] Signed-off-by: Lokesh Mandvekar <[email protected]>
8accf87
to
a5a5c6b
Compare
In answer to your question on the other thread: packit is not a blocker. slash-lgtm works just fine even with red packit. |
@edsantiago thanks. @vrothberg i'm hoping you can continue to ignore it :) . It does bother me too, but I'd rather it stare us (me) in the face than only get noticed during actual distro builds. Either way, I'm working on a fix on the other PR, should be in soon. I'm fine if we go ahead with this PR, until then |
Yeah, packit red status is ugly-scary, but it's temporary and I think we can learn from it. I still have grave concerns about packit, but would like to see what other failure modes it has before we disable it (or improve it). |
Yes, I am cool with that. I implied that it's blocking since some PRs were force merged after the lgtm. Feel free to close and apologies for the noise. |
I wonder if that was merge bot being way slower than usual. I've often noticed that on some PRs.
Not at all. On second thoughts, let's get this in since the packit fix PR might take a while to get fully baked. |
Yep, came here to say that. mergebot has been hanging for O(many minutes) lately, sometimes O(hour). |
@vrothberg @edsantiago good to go |
/lgtm Thanks @lsm5 |
Packit will probably be brought back soon after including
fix-spec-file-action. See: PR #15457
This reverts commit d45a5d4.
Signed-off-by: Lokesh Mandvekar [email protected]
Does this PR introduce a user-facing change?
@vrothberg @edsantiago PTAL