Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily Revert "Packit: Enable scratch build testing for Fedora 36, 37 and Rawhide" #15480

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Aug 25, 2022

Packit will probably be brought back soon after including
fix-spec-file-action. See: PR #15457

This reverts commit d45a5d4.

Signed-off-by: Lokesh Mandvekar [email protected]

Does this PR introduce a user-facing change?

None

@vrothberg @edsantiago PTAL

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2022
…6, 37 and Rawhide"

Packit will probably be brought back soon after including
fix-spec-file-action. See: PR containers#15457

This reverts commit d45a5d4.

[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5 lsm5 force-pushed the tmp-revert-packit branch from 8accf87 to a5a5c6b Compare August 25, 2022 13:18
@edsantiago
Copy link
Member

In answer to your question on the other thread: packit is not a blocker. slash-lgtm works just fine even with red packit.

@lsm5
Copy link
Member Author

lsm5 commented Aug 25, 2022

In answer to your question on the other thread: packit is not a blocker. slash-lgtm works just fine even with red packit.

@edsantiago thanks.

@vrothberg i'm hoping you can continue to ignore it :) . It does bother me too, but I'd rather it stare us (me) in the face than only get noticed during actual distro builds. Either way, I'm working on a fix on the other PR, should be in soon. I'm fine if we go ahead with this PR, until then

@edsantiago
Copy link
Member

Yeah, packit red status is ugly-scary, but it's temporary and I think we can learn from it. I still have grave concerns about packit, but would like to see what other failure modes it has before we disable it (or improve it).

@vrothberg
Copy link
Member

Yes, I am cool with that. I implied that it's blocking since some PRs were force merged after the lgtm.

Feel free to close and apologies for the noise.

@lsm5
Copy link
Member Author

lsm5 commented Aug 25, 2022

Yes, I am cool with that. I implied that it's blocking since some PRs were force merged after the lgtm.

I wonder if that was merge bot being way slower than usual. I've often noticed that on some PRs.

Feel free to close and apologies for the noise.

Not at all. On second thoughts, let's get this in since the packit fix PR might take a while to get fully baked.

@edsantiago
Copy link
Member

Yep, came here to say that. mergebot has been hanging for O(many minutes) lately, sometimes O(hour).

@lsm5
Copy link
Member Author

lsm5 commented Aug 25, 2022

@vrothberg @edsantiago good to go

@edsantiago
Copy link
Member

/lgtm

Thanks @lsm5

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2022
@openshift-merge-robot openshift-merge-robot merged commit f98215c into containers:main Aug 25, 2022
@lsm5 lsm5 deleted the tmp-revert-packit branch March 16, 2023 11:25
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants